fix(tui): defer prompt.set() to prevent crash when using --prompt flag#7869
Closed
ryanrhughes wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(tui): defer prompt.set() to prevent crash when using --prompt flag#7869ryanrhughes wants to merge 1 commit intoanomalyco:devfrom
ryanrhughes wants to merge 1 commit intoanomalyco:devfrom
Conversation
Fixes anomalyco#7818 The parent's onMount runs before the child Prompt component's onMount, so the prompt ref is undefined when prompt.set() is called. Using queueMicrotask() defers execution until after the child's onMount completes and the ref is available.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
|
Regression was fixed in 3a30773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a regression caused by #7702 that causes a crash when using the
--promptflag.Fixes #7818
Fixes #7850
How did you verify your code works?
I ran tests with
--promptpopulated and without, as well as tested that you can still successfully fork from the first message so as to not cause any regression from the original PR.